Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use_starttls config #7

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Add use_starttls config #7

merged 5 commits into from
Jul 28, 2023

Conversation

dontseyit
Copy link
Member

No description provided.

@dontseyit dontseyit requested a review from Cito July 28, 2023 11:00
Cito
Cito requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one suggestion below.

ns/adapters/outbound/smtp_client.py Outdated Show resolved Hide resolved
@Cito Cito requested a review from TheByronHimes July 28, 2023 11:42
TheByronHimes
TheByronHimes previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer have the awkward debugging flag, nice. This seems like a good solution to me.

@dontseyit dontseyit requested a review from Cito July 28, 2023 12:43
@dontseyit dontseyit merged commit 8af81c2 into main Jul 28, 2023
5 checks passed
@dontseyit dontseyit deleted the feature/use-starttls-config-GIM-301 branch July 28, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Cito approved these changes

@TheByronHimes TheByronHimes TheByronHimes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dontseyit @Cito @TheByronHimes