Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template updates (GSI613) #18

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Conversation

TheByronHimes
Copy link
Member

This PR includes the normal template updates, but it also required changes to the tests because of the pytest-asyncio update.
In short, the DB population logic that was packed in with the consumer fixture needed to be pulled into a separate sync fixture. All the test changes aside from the added scope arguments are due to that.

mephenor
mephenor previously approved these changes Feb 7, 2024
Copy link
Member

@mephenor mephenor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one tiny thing that should be simplified remains

tests/conftest.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7811700004

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.216%

Totals Coverage Status
Change from base Build 7113149376: 0.0%
Covered Lines: 455
Relevant Lines: 510

💛 - Coveralls

@TheByronHimes TheByronHimes merged commit e079dbc into main Feb 7, 2024
9 checks passed
@TheByronHimes TheByronHimes deleted the feature/template_updates_GSI-613 branch February 7, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants