Improve usage of context #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghivert
force-pushed
the
fix/improve-usage-of-context
branch
2 times, most recently
from
01e00ec
to
4c83770
Compare
ghivert
force-pushed
the
fix/improve-usage-of-context
branch
from
4c83770
to
1a1aace
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create_contextis barely usable right now, and is almost a React anti-pattern (because we'd have to pass theContextin every functions, which breaks the "no props-drilling" ability of Contexts). All Context in React should be declared once, at the top-level, and reuse after this.In the future,
create_context_should still exists, in case anyone wants to build other abstractions on top ofContext, while Redraw will push for the usage ofcontext. Contrarily to Lustre, Redraw is effectful, and as such, accepts to trigger side-effects like this in components functions.This PR fixes that behaviour, by emulating the same behaviour in Redraw.