Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respect aliases in scriptlet exceptions #4152

Conversation

seia-soto
Copy link
Member

@seia-soto seia-soto commented Jul 29, 2024

fixes #4058

TODO

  • Add tests
  • Add an ability to cache the normalised selector in somewhere
  • Confirm the behavior in other abilities like "resource redirects"
  • Update engine serialization version (as a last action)

@seia-soto seia-soto marked this pull request as ready for review July 30, 2024 02:46
@seia-soto seia-soto requested a review from remusao as a code owner July 30, 2024 02:46
@philipp-classen philipp-classen added the PR: Bug Fix 🐛 Increment patch version when merged label Jul 30, 2024
Copy link
Member

@chrmod chrmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when looking over this PR I've realised modern scriptlets have more attributes to them. Specifically we should support: aliases, trusted flag, content script/page script flag.
All that, together with a fact we bundle scriptlet dependencies, may already by sufficient to update our approach and move scriptlets out of resources.txt to a separate subsystem.

Lets discuss

@seia-soto seia-soto marked this pull request as draft August 2, 2024 06:15
@seia-soto
Copy link
Member Author

Closing with #4270

@seia-soto seia-soto closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 Increment patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adblocker: the library should respect the scriptlet alias in the exception filter
3 participants