Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX redesign and automatically launch CIQ app #8

Merged
merged 4 commits into from
Oct 30, 2022

Conversation

fm-sys
Copy link
Contributor

@fm-sys fm-sys commented Oct 12, 2022

Hi there,

I really love your app, so I did some work on it. Hope you like it as well :)

  • UX redesign
  • Connect via the Garmin android SDK and automatically launch the gimporter CIQ app

Note: this does not change the method how data is transferred in general (like suggested in #7). Therefore, this change is 100% backwards compatible and doesn't require any changes at the CIQ app.

Tested on Android 10 (API 29) and Android 4.4 (API 19)

Some screenshots

2 5 1 img
3 img img 6

@fm-sys
Copy link
Contributor Author

fm-sys commented Oct 27, 2022

Hi @haraldh,

May you take a look at these changes?

@haraldh
Copy link
Collaborator

haraldh commented Oct 28, 2022

@fm-sys , sorry, somehow this PR notification went unnoticed! Many thanks for your contribution. Will review and most likely merge the next days.

Copy link
Collaborator

@haraldh haraldh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing the binary jars from git?

@fm-sys
Copy link
Contributor Author

fm-sys commented Oct 28, 2022

Would you mind removing the binary jars from git?

I don't have a strong opinion about this, however it took me some time to figure out where to download the right files. Maybe we add links to the README instead?

@haraldh
Copy link
Collaborator

haraldh commented Oct 28, 2022

Would you mind removing the binary jars from git?

I don't have a strong opinion about this, however it took me some time to figure out where to download the right files. Maybe we add links to the README instead?

make it so 😀

@fm-sys
Copy link
Contributor Author

fm-sys commented Oct 28, 2022

Would you mind removing the binary jars from git?

I don't have a strong opinion about this, however it took me some time to figure out where to download the right files. Maybe we add links to the README instead?

make it so 😀

OK, done ;-)

@haraldh
Copy link
Collaborator

haraldh commented Oct 28, 2022

And now the last commit should be a fixup/squash with the first commit. Please rebase.

@haraldh
Copy link
Collaborator

haraldh commented Oct 28, 2022

and force push

@fm-sys
Copy link
Contributor Author

fm-sys commented Oct 28, 2022

Git challenge completed ;-)

@fm-sys fm-sys requested a review from haraldh October 29, 2022 15:35
@haraldh
Copy link
Collaborator

haraldh commented Oct 29, 2022

come on.. give me time.. I have family and a life 😀

@fm-sys
Copy link
Contributor Author

fm-sys commented Oct 29, 2022

Sure, no hurry. Take your time 👍

@haraldh haraldh merged commit ae26afb into gimportexportdevs:master Oct 30, 2022
@haraldh
Copy link
Collaborator

haraldh commented Oct 31, 2022

Thank you very much! Due to Google wanting API Level >= 30, I had to add some Directory export button. Otherwise only file sharing would have worked.

@fm-sys
Copy link
Contributor Author

fm-sys commented Oct 31, 2022

Thank you very much!

You're welcome! I am glad to be able to help :)

I had to add some Directory export button.

Thanks for adding this cool feature 👍

However, may I suggest some GUI cleanup?

  • The button looks quite nailed currently. Add some margin...
  • While "Connectivity", "Settings" and "Files" are three different topics and justify their own card, I would suggest placing the directory export button inside the "Files" card

If you don't mind, I can open a small PR...

img

@fm-sys fm-sys deleted the dev branch October 31, 2022 17:38
@fm-sys fm-sys mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants