Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround: trigger transitionend manually #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shgeum
Copy link

@shgeum shgeum commented May 19, 2023

When activeFilter and targetFilter were the same, there was an issue where the transition did not occur and the event of transitionend was not triggered, resulting in a huge amount of blank space when scrolling inside with max-height specified and overflow-y: scroll.

This happened because
filterItems.styles.resetDisplay(); : Filterizr.ts:211
Afterwards, any items that were display:none will be visible again, but if you call
Since setHidden() is handled by the transitionend event, if the transition didn't happen, they would not be display: none again.

I've now patched it to force it to trigger the event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant