Workaround: trigger transitionend manually #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
activeFilter
andtargetFilter
were the same, there was an issue where the transition did not occur and the event oftransitionend
was not triggered, resulting in a huge amount of blank space when scrolling inside withmax-height
specified andoverflow-y: scroll
.This happened because
filterItems.styles.resetDisplay();
: Filterizr.ts:211Afterwards, any items that were
display:none
will be visible again, but if you callSince
setHidden()
is handled by thetransitionend
event, if the transition didn't happen, they would not bedisplay: none
again.I've now patched it to force it to trigger the event.