gogio: add deeplink support #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That depends on gioui/gio#117 |
eliasnaur
reviewed
Jul 17, 2023
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
That change adds `-deeplink` flag. Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
Signed-off-by: inkeliz <[email protected]>
eliasnaur
reviewed
Jun 7, 2024
Signed-off-by: inkeliz <[email protected]>
eliasnaur
reviewed
Jun 16, 2024
| @@ -291,7 +296,7 @@ func iosIcons(bi *buildInfo, tmpDir, appDir, icon string) (string, error) { | |||
| return assetPlist, err | |||
| } | |||
|
|
|||
| func buildInfoPlist(bi *buildInfo) string { | |||
| func buildInfoPlist(bi *buildInfo) (string, error) { | |||
There was a problem hiding this comment.
I don't think this function can return a non-nil error anymore.
| @@ -124,6 +125,19 @@ func (b *macBuilder) setIcon(path string) (err error) { | |||
| } | |||
|
|
|||
| func (b *macBuilder) setInfo(buildInfo *buildInfo, name string) error { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.