Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor update_comment() #354

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Refactor update_comment() #354

merged 1 commit into from
Oct 27, 2024

Conversation

hiroshinishio
Copy link
Collaborator

@hiroshinishio hiroshinishio commented Oct 27, 2024

Summary by Sourcery

Enhancements:

  • Refactor the update_comment function to use base_args for passing parameters, simplifying the function signature and improving code readability.

Copy link

sentry-io bot commented Oct 27, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: services/check_run_handler.py

Function Unhandled Issue
handle_check_run IndexError: list index out of range /webhook
Event Count: 79
handle_check_run KeyError: 'pull_requests' /webhook
Event Count: 2
handle_check_run KeyError: 'owner' /webhook
Event Count: 2
handle_check_run KeyError: 'update_github_comment' /webhook
Event Count: 1

Did you find this useful? React with a 👍 or 👎

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hiroshinishio - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider preserving some of the detailed error handling from update_comment_for_raised_errors(), particularly for HTTP 422 status codes, to maintain debugging capabilities in production. The current simplification might make troubleshooting more difficult.
Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

services/github/github_manager.py Show resolved Hide resolved
services/gitauto_handler.py Show resolved Hide resolved
@hiroshinishio hiroshinishio merged commit a1f1aaa into main Oct 27, 2024
2 checks passed
Copy link

sentry-io bot commented Oct 28, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ValueError: not enough values to unpack (expected 4, got 3) /jira-webhook View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant