Tauri v1 -> v2 #4789
Open
Tauri v1 -> v2 #4789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtsgrd
commented
Aug 29, 2024
•
mtsgrd
commented
- rewrite of app updater because of new api
- webkit2gtk 4.0 -> 4.1 upgrade, will now work without appimage on Ubuntu 24.04
- webdriver actions API now working
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
rust
|
Part of #4694 |
mtsgrd
changed the title
mtsgrd
force-pushed
the
Tauri-v1-to-v2
branch
from
bb4efeb
to
0a8f48a
Compare
mtsgrd
force-pushed
the
Tauri-v1-to-v2
branch
from
50f450b
to
80042ed
Compare
- different dependencies -> different cache
mtsgrd
force-pushed
the
Tauri-v1-to-v2
branch
from
80042ed
to
ef5d2b9
Compare
mtsgrd
force-pushed
the
Tauri-v1-to-v2
branch
from
ef5d2b9
to
99ccb73
Compare
mtsgrd
force-pushed
the
Tauri-v1-to-v2
branch
from
99ccb73
to
1a8ba12
Compare
krlvi
reviewed
Oct 24, 2024
| @@ -27,7 +27,7 @@ | |||
| loading = true; | |||
| try { | |||
| // TODO: Refactor temporary solution to forcing Windows to use system executable | |||
| if ($platformName === 'win32') { | |||
| if (platformName === 'windows') { | |||
There was a problem hiding this comment.
They are enumerated so typescript complains if you are using an incorrect value.
mtsgrd
force-pushed
the
Tauri-v1-to-v2
branch
from
1a8ba12
to
bc2027e
Compare
krlvi
reviewed
Oct 24, 2024
| * The application metrics can be enabled or disabled by setting the value of the store to true or false. | ||
| * @returns A writable store with the appMetricsEnabled config. | ||
| */ | ||
| readonly appMetricsEnabled = this.persisted(true, 'appMetricsEnabled'); |
There was a problem hiding this comment.
these still work correctly, right?
There was a problem hiding this comment.
yes, but let me also test this manually before landing these changes.
krlvi
reviewed
Oct 24, 2024
krlvi
reviewed
Oct 24, 2024
krlvi
reviewed
Oct 24, 2024
| [ -z "${APPLE_ID-}" ] && error "$APPLE_ID is not set" | ||
| [ -z "${APPLE_TEAM_ID-}" ] && error "$APPLE_TEAM_ID is not set" | ||
| [ -z "${APPLE_PASSWORD-}" ] && error "$APPLE_PASSWORD is not set" | ||
| export APPLE_CERTIFICATE="$APPLE_CERTIFICATE" | ||
| export APPLE_CERTIFICATE_PASSWORD="$APPLE_CERTIFICATE_PASSWORD" | ||
| export APPLE_SIGNING_IDENTITY="$APPLE_SIGNING_IDENTITY" |
There was a problem hiding this comment.
I remember nightly failed to build unless I removed it, but I think we should investigate further.
Refactor appSettings to accommodate new Tauri v2 API - creates AppSettings class and injects it where needed - avoids `window` undeclared variable during vite build process
mtsgrd
force-pushed
the
Tauri-v1-to-v2
branch
from
bc2027e
to
ef0a800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.