Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: series header description field #5041

Closed
wants to merge 6 commits into from

Conversation

ndom91
Copy link
Contributor

@ndom91 ndom91 commented Oct 4, 2024

☕️ Reasoning

  • Allow both adding and removing "description" field to series via kebab menu "Add/Remove description" option on Series header (StackingBranchHeader.svelte)
  • Extract InputLabel.svelte into own component and allow two variants - input and textarea for single and multi-line versions

🧢 Changes

  • Extracted existing BranchLabel.svelte combination label/input field into InputLabel.svelte which then is used by BranchLabel/StackingBranchDescription(new)

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitbutler-web ⬜️ Skipped (Inspect) Oct 9, 2024 0:37am

…riants

fix: autoSelectBranchName feature flag behaviour
Merge branch 'master' into ndom91/series-description-field
Merge branch 'master' into ndom91/series-description-field
fix: prettier
Merge branch 'master' into ndom91/series-description-field
@ndom91
Copy link
Contributor Author

ndom91 commented Oct 10, 2024

This PR is waiting on this ESLint issue to be fixed first: #5083

@ndom91
Copy link
Contributor Author

ndom91 commented Oct 16, 2024

There have been too many upstream changes. This branch / PR has been replaced via: #5172

@ndom91 ndom91 closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@gitbutler/desktop @gitbutler/ui rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants