Modal: Close is a promise + onClickOutside #5325
Merged
+29
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the modal closing function a promise as it's done asynchronously. Add another optional callback that's called only in the case when clicking outside the modal.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mtsgrd
reviewed
Oct 28, 2024
packages/ui/src/lib/Modal.svelte
Outdated
| @@ -52,14 +63,20 @@ | |||
| window.addEventListener('keydown', handleKeyDown); | |||
| } | |||
| export function close() { | |||
| export function close(): Promise<void> { | |||
| if (isClosing) return Promise.resolve(); | |||
There was a problem hiding this comment.
If this function is called twice, then it looks to me like the second call would resolve immediately while the original resolves in 100ms. Is this intended?
There was a problem hiding this comment.
You're right. Makes sense to resolve the promise only until it's fully closed, regardless of if the function is called a second time
mtsgrd
approved these changes
Oct 28, 2024
estib-vega
force-pushed
the
modal-improvements
branch
from
7bcb7e9
to
7b0e447
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Enhance modal functionality by making the closing process a promise and adding an optional callback for clicking outside the modal.
🧢 Changes