Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment creation with prevent_self_review #630

Draft
wants to merge 1 commit into
base: main-enterprise
Choose a base branch
from

Conversation

igorcosta
Copy link
Contributor

@igorcosta igorcosta commented May 15, 2024

Related to #628

Implements validation and error handling for environment creation with prevent_self_review enabled in lib/plugins/environments.js.

  • Updates the environment creation and update logic to ensure that at least one reviewer is present when prevent_self_review is set to true. This prevents the creation of environments without reviewers, addressing the issue where environments were partially created on the first attempt and required a restart to complete.
  • Adds error logging to clearly indicate when the creation process is halted due to the absence of reviewers, improving the visibility of the issue and aiding in troubleshooting.
  • Ensures that environments with the correct configuration of reviewers and prevent_self_review are created successfully in a single pass, eliminating the need for partial provisioning or errors that lead to pod restarts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant