Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 2: Prototype-polluting function #694

Draft
wants to merge 1 commit into
base: main-enterprise
Choose a base branch
from

Conversation

decyjphr
Copy link
Collaborator

Fixes https://github.com/github/safe-settings/security/code-scanning/2

To fix the prototype pollution vulnerability, we need to ensure that properties like __proto__ and constructor are not copied from the source object to the modifications object. This can be achieved by adding a check to skip these properties during the merge process.

  • Add a check to skip __proto__ and constructor properties in the for...in loop that iterates over source.
  • This change should be made in the compareDeep method of the MergeDeep class in the lib/mergeDeep.js file.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant