Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a Makefile #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Add a Makefile #141

wants to merge 1 commit into from

Conversation

sylver
Copy link

@sylver sylver commented Nov 19, 2023 •
edited
Loading

  • Idiomatic way of managing install/uninstall files
  • OS Agnostic (Linux, MacOS, Windows)

Obsoletes #8 #64 #66 #71 #82 #89 #98 #104 #107 #108 #123 #151 #153
Fixes #63
Fixes #93

@sylver
Copy link
Author

sylver commented Nov 19, 2023

I tried to test it extensively on all 3 OSes, so far it works, but more tests/feedback from the community are welcomed

@zanieb zanieb mentioned this pull request Nov 27, 2023
Closed
@sylver
chore: Add a Makefile
705481f 
* Idiomatic way of managing install/uninstall files
* OS Agnostic (Linux, MacOS, Windows)
offensive-vk
offensive-vk approved these changes Jun 12, 2024
View reviewed changes
Copy link

@offensive-vk offensive-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any need of deleting those install scripts for macos and linux?

@sylver
Copy link
Author

sylver commented Jun 13, 2024

Is there any need of deleting those install scripts for macos and linux?

Hey @offensive-vk, thanks for the approval.

From my standpoint, having a single method is preferable:

  • Easier maintenance
  • Simplicity and straightforwardness for users
  • No need to keep both scripts; make is available by default on macOS and Linux and is a more standard way to manage files install/uninstall. While I wouldn't suggest this for a Windows script, but you don't have one yet.

@rcardocabrra4
Copy link

Give me result to email [email protected]

barnett-yuxiang
barnett-yuxiang reviewed Jun 23, 2024
View reviewed changes
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heathercran heathercran added this to the 1.2 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnett-yuxiang barnett-yuxiang barnett-yuxiang left review comments

@rcardocabrra4 rcardocabrra4 rcardocabrra4 approved these changes

@offensive-vk offensive-vk offensive-vk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Monaspace Planning
Status: No status
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Linux Bash script is wrong. FIX HERE! Linux Install Script Issues
5 participants
@sylver @rcardocabrra4 @barnett-yuxiang @offensive-vk @heathercran