Install scripts bash improvements #266
Open
+26
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original scripts were forcing the caller to be in the monospace directory and calling `./util/install_XXX.sh`. You can now execute `install_XXX.sh` from wherever you want. ex: `~/Downloads/monaspace-v1.101/util/install_macos.sh`
`#!/usr/bin/env` searches `PATH` for `bash`, and `bash` is not always in `/bin`, particularly on non-Linux systems. See https://en.wikipedia.org/wiki/Shebang_(Unix)#Portability
Would easily allow letting caller choose output dir for instance.
```bash
fonts_dir="${1:-"${HOME}/Library/Fonts"}"
```
Note:
Used `${HOME}` as a replacement of `~` which doesn't expands within quotes.
See https://www.shellcheck.net/wiki/SC2088
|
I just noticed I went a bit quickly and missed PR #218 My version follows the same logic but goes a step beyond and also handles macOS though. |
|
Also relates to PR #239 |
|
Just want to say that this is an important PR because it fixes the shebang. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original motivation was to let me call the
util/install_macos.shscript from anywhere, which was my original intent to install the fonts.I downloaded and extracted the zip somewhere, then from the working dir I was in, I just called
~/Downloads/monaspace-v1.101/util/install_macos.shand it failed.With the first commit, it can now be called from anywhere.
While I was as it, I suggested some improvements (maybe a bit opinionated?), feel free to request removal of some if it doesn't suit your practices.
There are several commits to better isolate changes.
Commits detailed message contain motivation/explanation when relevant if you need.