-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub CLI to course preparation #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. This is a great addition. 😀
Head branch was pushed to by a user without write access
@amyschoen Workflows waiting approval. Thanks. |
Apologies. I didn't realize the linter needed explicit approval. |
Head branch was pushed to by a user without write access
Co-authored-by: Parker Brown <[email protected]>
@amyschoen @parkerbxyz Workflow waiting approval. THX |
@amyschoen @parkerbxyz I believe we need a CODEOWNERS Approval from @githubtraining/github-delivery-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It just needs a new approving review since new commits were pushed.
The actual pre requisites does not avoid issues with it authentication.
Managing this authentication failing during the course is complicated.
GitHub Cli has the ability to set and managed git authentication very easily.
Adding the installation of GitHub CLI in the attendees computers allows an easy fixing for the teacher if needed with any attendee.