Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub CLI to course preparation #416

Merged
merged 5 commits into from
May 10, 2024
Merged

Conversation

rulasg
Copy link
Contributor

@rulasg rulasg commented Apr 17, 2024

The actual pre requisites does not avoid issues with it authentication.

Managing this authentication failing during the course is complicated.

GitHub Cli has the ability to set and managed git authentication very easily.

gh auth login

Adding the installation of GitHub CLI in the attendees computers allows an easy fixing for the teacher if needed with any attendee.

@rulasg rulasg requested a review from a team as a code owner April 17, 2024 20:29
amyschoen
amyschoen previously approved these changes Apr 19, 2024
Copy link
Collaborator

@amyschoen amyschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This is a great addition. 😀

auto-merge was automatically disabled April 29, 2024 08:11

Head branch was pushed to by a user without write access

@rulasg
Copy link
Contributor Author

rulasg commented May 8, 2024

@amyschoen Workflows waiting approval. Thanks.

@amyschoen amyschoen enabled auto-merge May 8, 2024 13:13
@amyschoen
Copy link
Collaborator

Apologies. I didn't realize the linter needed explicit approval.

@parkerbxyz parkerbxyz changed the title Ad GitHub cli on the course preparation Add GitHub CLI to course preparation May 8, 2024
auto-merge was automatically disabled May 9, 2024 06:04

Head branch was pushed to by a user without write access

@rulasg
Copy link
Contributor Author

rulasg commented May 9, 2024

@amyschoen @parkerbxyz Workflow waiting approval. THX

@rulasg
Copy link
Contributor Author

rulasg commented May 10, 2024

@amyschoen @parkerbxyz I believe we need a CODEOWNERS Approval from @githubtraining/github-delivery-reviewers
Any chance to confirm that this is on their radar?

Copy link
Contributor

@parkerbxyz parkerbxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just needs a new approving review since new commits were pushed.

@parkerbxyz parkerbxyz merged commit 57bf9ef into githubtraining:main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants