Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project Access Tokens #1018

Merged
merged 18 commits into from
Aug 23, 2023
Merged

Add Project Access Tokens #1018

merged 18 commits into from
Aug 23, 2023

Conversation

bensofficial
Copy link
Contributor

@bensofficial bensofficial commented Aug 16, 2023

For further development within the Artemis project we need project access tokens. Therefore, we implemented the corresponding feature.

This PR adds the methods to interact with the project access tokens API provided by GitLab.

I have tested the newly introduced methods with GitLab version 13.10.

If you have questions, please let us know.

Closes #693

@bensofficial
Copy link
Contributor Author

bensofficial commented Aug 18, 2023

@jmini Thank you for your feedback 🙏 . I implemented your suggestions.

@bensofficial
Copy link
Contributor Author

Regarding the failing test case: Some of the API endpoints have been added in GitLab release 14.10 and 16.0 (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82714 or https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120436). As the tests currently run against GitLab 13.9 the newly added test cases will fail for an obvious reason.
Maybe I should disable the tests until the version of the GitLab instance is updated in the pom.xml. What do you think @jmini?

@jmini
Copy link
Collaborator

jmini commented Aug 21, 2023

As the tests currently run against GitLab 13.9 the newly added test cases will fail for an obvious reason.
Maybe I should disable the tests until the version of the GitLab instance is updated in the pom.xml.

Yes I think we already did something like that in #963 just adding a NOTE.

There is an idea to switch the GitLab instance that used in the integration tests #925, but I don't know if there are any progress.
Once we have a more recent version, we can enable back those tests.

@bensofficial
Copy link
Contributor Author

Great. I will add it tomorrow, and then the PR is good to go 😄

@bensofficial
Copy link
Contributor Author

@jmini I have now commented out the affected lines. Everything works now 👍

@jmini jmini merged commit 2d9a588 into gitlab4j:main Aug 23, 2023
1 check passed
@jmini
Copy link
Collaborator

jmini commented Aug 23, 2023

Merged, thank you very much for this contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for project access token CRUD
2 participants