Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deployment and enviorment attributes #1187

Open
wants to merge 6 commits into
base: 6.x
Choose a base branch
from

Conversation

katrinSaleschus
Copy link
Contributor

No description provided.

Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests should be added

@katrinSaleschus katrinSaleschus marked this pull request as draft November 7, 2024 09:01
@katrinSaleschus katrinSaleschus force-pushed the addMissingDeploymentAndEnviormentAttributes branch from afdc6c7 to 4844253 Compare November 12, 2024 08:24
# Conflicts:
#	src/main/java/org/gitlab4j/api/models/Environment.java
#	src/test/java/org/gitlab4j/api/TestGitLabApiEvents.java
@katrinSaleschus katrinSaleschus marked this pull request as ready for review November 13, 2024 09:26
@katrinSaleschus
Copy link
Contributor Author

Thank you for your Review. Now everything should be ok to merge.

@jmini
Copy link
Collaborator

jmini commented Nov 18, 2024

I will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants