Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added response headers to GitLabApiException #973

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

Walti91
Copy link
Contributor

@Walti91 Walti91 commented May 4, 2023

No description provided.

@jmini
Copy link
Collaborator

jmini commented May 4, 2023

The CI error is unrelated with this change. We need to merge #970 or an equivalent solution

@jmini jmini changed the base branch from 6.x to main May 5, 2023 10:05
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.

I have rebased the change on top of main and I have fixed the Unit Test that was failing (probably because we are testing against a very old GitLab instance (see #925 --> our plan to improve on this topic).

@jmini jmini merged commit 3cd0ab9 into gitlab4j:main May 5, 2023
@jmini
Copy link
Collaborator

jmini commented May 5, 2023

@Walti91 thank you for this contribution 🎉

It was merged to main and then to 6.x and will be available with the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants