Fix single section page navigation.

gjbarnard · Aug 1, 2024 · 4beaf73 · 4beaf73
1 parent 26b58b2
commit 4beaf73
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Changes.md b/Changes.md
@@ -4,6 +4,7 @@
 Version 404.1.1 - Development started
 ----------------------------
 1. Show section zero if the section has meaningful content.
+2. Fix single section page navigation.
 
 Version 404.1.0 - 01/07/2024
 ----------------------------

diff --git a/classes/output/courseformat/content/sectionnavigation.php b/classes/output/courseformat/content/sectionnavigation.php
@@ -73,21 +73,21 @@ public function export_for_template(\renderer_base $output): \stdClass {
                     $data->previoushidden = true;
                 }
                 $data->previousname = get_section_name($course, $sections[$back]);
-                $data->previousurl = course_get_url($course, $back, ['navigation' => true]);
+                $data->previousurl = $format->get_view_url($back, ['navigation' => false]);
                 $data->hasprevious = true;
             }
             $back--;
         }
 
         $forward = $this->sectionno + 1;
-        $numsections = course_get_format($course)->get_last_section_number();
+        $numsections = $format->get_last_section_number();
         while ($forward <= $numsections && empty($data->nexturl)) {
             if ($canviewhidden || $sections[$forward]->uservisible) {
                 if (!$sections[$forward]->visible) {
                     $data->nexthidden = true;
                 }
                 $data->nextname = get_section_name($course, $sections[$forward]);
-                $data->nexturl = course_get_url($course, $forward, ['navigation' => true]);
+                $data->nexturl = $format->get_view_url($forward, ['navigation' => false]);
                 $data->hasnext = true;
             }
             $forward++;

diff --git a/classes/output/courseformat/content/sectionselector.php b/classes/output/courseformat/content/sectionselector.php
@@ -64,7 +64,7 @@ public function export_for_template(\renderer_base $output): \stdClass {
         $numsections = $format->get_last_section_number();
         while ($section <= $numsections) {
             $thissection = $modinfo->get_section_info($section);
-            $url = course_get_url($course, $section, ['navigation' => true]);
+            $url = $format->get_view_url($section, ['navigation' => false]);
             if ($thissection->uservisible && $url && $section != $data->currentsection) {
                 $sectionmenu[$url->out(false)] = get_section_name($course, $section);
             }
@@ -76,6 +76,7 @@ public function export_for_template(\renderer_base $output): \stdClass {
         $select->formid = 'sectionmenu';
 
         $data->selector = $output->render($select);
+
         return $data;
     }
 }