Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check utf8 relative anchors #842

Merged
merged 3 commits into from
May 29, 2024
Merged

Check utf8 relative anchors #842

merged 3 commits into from
May 29, 2024

Commits on May 23, 2024

  1. Added test for UTF-8 encoded internal links 

    There wasn't a specific test for this, and it fails on some setups.

The link in the fixture is a direct copy-paste from one that fails on my project.

But the test passes on this test suite... So there is something else going on.

Relates to gjtorikian#757
    @ahpook
    ahpook committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4958ecb View commit details
    Browse the repository at this point in the history

  2. Reproducible case for anchor link encoding failures 

    Looking a little deeper into the source code of the failures, I noticed that not _all_ the non-ASCII links were failing, only some of them. The site gets built with relative links between pages, and it was links to another page with a "../page/#hash" syntax which failed.

This commit adds a test directory which mimics that structure and reliably reproduces the error... I think!
    @ahpook
    ahpook committed May 23, 2024
    2 Configuration menu
    Copy the full SHA
    5534884 View commit details
    Browse the repository at this point in the history

  3. Fix trailing whitespace

    @ahpook
    ahpook committed May 23, 2024
    Configuration menu
    Copy the full SHA
    3748112 View commit details
    Browse the repository at this point in the history