Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@glimmer/interfaces now uses extensions in its imports. #1555

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jan 30, 2024

This allows Node16 consumers to use @glimmer/interfaces.

None of the other @glimmer/* (vm) packages have this issue becaues they're all rollup'd to a single file. Rollup doesn't support .d.ts-only projects, and tsc doesn't support outputting to a single file in ESM projects (requires AMD or System module setting)


Since the (almost) entirety of the VM repo uses moduleResolution=bundler, this (VM) repo should still provide us with sufficient confidence that non-Node16 projects still work with @glimmer/interface's types.


Unblocks: typed-ember/glint#696
cc @patricklx

This allows Node16 consumers to use `@glimmer/interfaces`.

None of the other `@glimmer/*` (vm) packages have this issue becaues they're all rollup'd to a
single file. Rollup doesn't support .d.ts-only projects, and `tsc` doesn't support outputting to a
single file in ESM projects (requires AMD or System `module` setting)
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review January 30, 2024 17:17
@NullVoxPopuli NullVoxPopuli merged commit 59b207d into main Jan 31, 2024
5 of 6 checks passed
@NullVoxPopuli NullVoxPopuli deleted the use-explicit-extensions-to-support-Node16-environments-@glimmer-interfaces branch January 31, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant