-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework segment.key as segment.keys, a list of keys #313
Open
rlaphoenix
wants to merge
7
commits into
globocom:master
Choose a base branch
from
rlaphoenix:keep-preceeding-keys
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 9, 2023
-
Rework segment.key as segment.keys, a list of keys
This closes globocom#283 as it now follows RFC and keeps all preceding keys for the segment. - `m3u8_obj.keys` still has the same behaviour. - `m3u8_obj.segments[0].key` is now removed. - `m3u8_obj.segments[0].keys` is added in it's place, which will now always be a list. - The list will always be present, it will never be `None` anymore, and if the segment explicitly has no DRM by specifying an EXT-X-KEY of METHOD=NONE then it will be a list with that key. - It does not check if there's a METHOD=NONE with other conflicting EXT-X-KEY information. - It still follows the same behaviour of not duplicating the EXT-X-KEY information on future segments when dumping. Do note that it only clears the list of Keys when it reaches an EXT-X-DISCONTINUITY, or it has reached a ts segment. The copy() statement is used because it clears after the segment is appended to `data`, yet the .clear() to `current_keys` follows in the appended `segment` unless we copy that data in memory prior. I don't think there's a need for `.by_key()` or `m3u8_obj.keys` anymore, but I've made sure those still work as intended in case there's a different reason those exist.
Configuration menu - View commit details
-
Copy full SHA for e58e878 - Browse repository at this point
Copy the full SHA e58e878View commit details
Commits on Mar 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7102383 - Browse repository at this point
Copy the full SHA 7102383View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb0f245 - Browse repository at this point
Copy the full SHA cb0f245View commit details -
Re-implement Segment.key, having the last key within keys
This keeps compatibility and fixes a lot of the existing tests. However, new tests should likely be implemented for testing HLS playlists with multiple preceeding keys.
Configuration menu - View commit details
-
Copy full SHA for 69fa67e - Browse repository at this point
Copy the full SHA 69fa67eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36dbc84 - Browse repository at this point
Copy the full SHA 36dbc84View commit details -
This is because the segment may be constructed with both `key` and `keyobject` due to `Segment(..., **segment)` being done. Even though we do not use the `key` argument, we must define it.
Configuration menu - View commit details
-
Copy full SHA for fb266d0 - Browse repository at this point
Copy the full SHA fb266d0View commit details -
Fix model test, test_segment_attribute_with_multiple_keys
This code assumes that the key carries forward to the next segments, which even before my changes I don't believe it would. Either way it definitely doesn't now, and this would be correct behaviour.
Configuration menu - View commit details
-
Copy full SHA for dcadc0e - Browse repository at this point
Copy the full SHA dcadc0eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.