Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untrack ipynb in linguist #236

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Untrack ipynb in linguist #236

merged 4 commits into from
Sep 13, 2024

Conversation

janbridley
Copy link
Collaborator

@janbridley janbridley commented Aug 26, 2024

Description

Motivation and Context

Github linguist autoselects the language for a repository. For coxeter, this results in the following:

image

Listing the package as primarily jupyter notebook could be confusing,and as far as I know there is no GLSL code. Updating the .gitattributes is a minor fix but a useful one nonetheless

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

@janbridley
Copy link
Collaborator Author

@janbridley janbridley self-assigned this Sep 9, 2024
.gitattributes Outdated Show resolved Hide resolved
@janbridley
Copy link
Collaborator Author

janbridley commented Sep 9, 2024

$ github-linguist
100.00% 360976    python

linguist-vendored untracks a folder in linguist, and subfolders must be added with parent/** instead of parent/*. This is all set now!

@janbridley janbridley marked this pull request as ready for review September 9, 2024 15:48
Copy link
Member

@joaander joaander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@janbridley janbridley enabled auto-merge (squash) September 9, 2024 17:10
@janbridley
Copy link
Collaborator Author

Merge appears to be locked to admins only - I could override, but is there a systematic setting to change to fix this?

@janbridley janbridley merged commit bea5d84 into master Sep 13, 2024
9 checks passed
@janbridley janbridley deleted the fix/linguist branch September 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants