Update io module to more complex test case #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbridley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I decided a more complicated test case for the io module was a good idea. Unfortunately, it appears that the sorting of faces during the construction of shapes can be different between mac and linux systems. I believe this stems from quickhull, but I do not have data to back this up.
Solution
I have switched the test from a cube with integer vertices to an elongated pyramid. The new shape is (1) included with coxeter, (2) has multiple types of faces, and (3) is not centrosymetric. This seems like a reasonable level of complexity and appears to work on mac and linux test platforms.
Types of Changes
1The change breaks (or has the potential to break) existing functionality.
Checklist: