highlightspans: allow matching when span is first on the line #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdtournier
added a commit
to KCL-BMEIS/OOP
that referenced
this pull request
Oct 11, 2024
This includes a fix for code span highlighting. For details: gnab/remark#703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #615, which I've also been struggling with. This modifies the regex to also allow matching the start of the line as the only thing preceding the opening backtick. This seems to fix things in my limited testing, but I've no idea whether there are any other corner cases where this might not be the right thing to do...
As an aside, I would also suggest removing the custom padding for
remark-code-span-highlighted(this line), as this causes the text to shift when displaying the same code segment across two slides when only one of them contains a code span highlight. This is easy to fix with some custom CSS, but it would be good to have this as the default behaviour.