Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the network port scanning support / 네트워크 포트 스캐닝 지원 #24

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

gnh1201
Copy link
Owner

@gnh1201 gnh1201 commented Jul 4, 2024


def dispatch(self, type, id, params, conn):
hosts = params['hosts']
binpath = params['binpath']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binpath는 불필요한 것 같습니다.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nmap 도구에 의존하므로 바이너리 경로를 알려줄 필요가 있어 추가되었습니다. 향후 더 좋은 방법이 있는지 고민해보겠습니다.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 소스코드 상으로는 binpath 변수를 사용하지 않는 것 같은데요, 혹시 다른곳에서 사용중인걸까요?

Copy link
Collaborator

@AkiaCode AkiaCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/nmap.py Show resolved Hide resolved
Copy link
Collaborator

@zeroday0619 zeroday0619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server.py Outdated Show resolved Hide resolved
@gnh1201 gnh1201 changed the title Add the network port scanning support Add the network port scanning support / 네트워크 포트 스캐닝 지원 Jul 9, 2024
@gnh1201 gnh1201 merged commit 352fc32 into main Jul 9, 2024
gnh1201 added a commit that referenced this pull request Jul 9, 2024
@gnh1201 gnh1201 deleted the nmap branch July 9, 2024 06:55
gnh1201 added a commit that referenced this pull request Jul 11, 2024
gnh1201 added a commit that referenced this pull request Jul 11, 2024
This reverts commit fffac9d.
gnh1201 added a commit that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants