-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the network port scanning support / 네트워크 포트 스캐닝 지원 #24
Conversation
plugins/portscan.py
Outdated
|
||
def dispatch(self, type, id, params, conn): | ||
hosts = params['hosts'] | ||
binpath = params['binpath'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
binpath
는 불필요한 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nmap 도구에 의존하므로 바이너리 경로를 알려줄 필요가 있어 추가되었습니다. 향후 더 좋은 방법이 있는지 고민해보겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 소스코드 상으로는 binpath
변수를 사용하지 않는 것 같은데요, 혹시 다른곳에서 사용중인걸까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Create nmap.py
Related links