-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: txtar tests load full config and execute serially #1342
fix: txtar tests load full config and execute serially #1342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! fix a regression introduced by #1241
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1342 +/- ##
==========================================
+ Coverage 55.90% 55.96% +0.05%
==========================================
Files 420 420
Lines 65373 65380 +7
==========================================
+ Hits 36549 36592 +43
+ Misses 25968 25931 -37
- Partials 2856 2857 +1
☔ View full report in Codecov by Sentry. |
I moved it back to draft status. There is an issue where running multiple txtar tests (see txtar test added in this PR) results in one of them always failing with the error: |
Yes, Txtar enforces for running tasks at the same time. We need to either improve how Gnoland handles concurrency or change Txtar to run tasks one after the other. |
If it's really a memory problem, another good solution would be to build & exec gnoland the same way we do with gno so it will have its own process, and no more memory conflict. |
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
Signed-off-by: gfanton <[email protected]>
This fixes an issue where executing txtar tests would fail because the example packages weren't loaded into memory. <details><summary>Contributors' checklist...</summary> - [x] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Signed-off-by: gfanton <[email protected]> Co-authored-by: gfanton <[email protected]>
This fixes an issue where executing txtar tests would fail because the example packages weren't loaded into memory.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description