Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix: handle assignments to dereferenced pointer values #1501

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

this almost works but alas...

0e6e0db
Select commit
Loading
Failed to load commit list.
Draft

WIP fix: handle assignments to dereferenced pointer values #1501

this almost works but alas...
0e6e0db
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2024 in 0s

55.75% (-0.34%) compared to b525e8b

View this Pull Request on Codecov

55.75% (-0.34%) compared to b525e8b

Details

Codecov Report

Attention: 134 lines in your changes are missing coverage. Please review.

Comparison is base (b525e8b) 56.08% compared to head (0e6e0db) 55.75%.
Report is 6 commits behind head on master.

Files Patch % Lines
gnovm/pkg/gnolang/values.go 27.95% 115 Missing and 1 partial ⚠️
gnovm/pkg/gnolang/realm.go 26.66% 9 Missing and 2 partials ⚠️
gnovm/pkg/gnolang/ownership.go 42.85% 4 Missing ⚠️
gnovm/pkg/gnolang/op_exec.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1501      +/-   ##
==========================================
- Coverage   56.08%   55.75%   -0.34%     
==========================================
  Files         432      431       -1     
  Lines       66000    66639     +639     
==========================================
+ Hits        37016    37153     +137     
- Misses      26095    26578     +483     
- Partials     2889     2908      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.