Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnovm): correct type comparison for bool type #2725

Merged

Conversation

ltzmaxwell
Copy link
Contributor

@ltzmaxwell ltzmaxwell commented Aug 22, 2024

This closes #2719.

copy from #2719:

#1890 introduced strict type comparison, which is the correct approach but overlooked the problem mentioned above, resulting in the comparison between bool and untyped bool. I will provide a fix soon.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Aug 22, 2024
@ltzmaxwell ltzmaxwell changed the title fix(gnome): correct type comparison for untyped bool type fix(gnovm): correct type comparison for untyped bool type Aug 22, 2024
@ltzmaxwell ltzmaxwell changed the title fix(gnovm): correct type comparison for untyped bool type fix(gnovm): correct type comparison for bool type Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (aae5d49) to head (60b6697).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2725      +/-   ##
==========================================
- Coverage   60.23%   60.21%   -0.02%     
==========================================
  Files         562      562              
  Lines       75091    75028      -63     
==========================================
- Hits        45228    45181      -47     
+ Misses      26482    26474       -8     
+ Partials     3381     3373       -8     
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 64.61% <ø> (-0.16%) ⬇️
gnovm 64.33% <100.00%> (+<0.01%) ⬆️
misc/genstd 80.54% <ø> (ø)
misc/logos 20.23% <ø> (ø)
tm2 62.01% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@deelawn deelawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left one suggestion.

gnovm/pkg/gnolang/preprocess.go Show resolved Hide resolved
@notJoon
Copy link
Member

notJoon commented Aug 23, 2024

It runs very well. nice 👍

@r3v4s
Copy link
Contributor

r3v4s commented Aug 23, 2024

test runs well :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Unexpected Boolean Comparison Results
4 participants