-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add r/leon
#2740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
🧾 package/realm
Tag used for new Realms or Packages.
label
Aug 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
=======================================
Coverage 60.22% 60.22%
=======================================
Files 562 562
Lines 75038 75038
=======================================
+ Hits 45188 45189 +1
+ Misses 26476 26474 -2
- Partials 3374 3375 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leohhhn
requested review from
jaekwon and
zivkovicmilos
and removed request for
a team
August 30, 2024 13:30
deelawn
reviewed
Aug 30, 2024
moul
approved these changes
Sep 1, 2024
deelawn
approved these changes
Sep 3, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds v1 of
r/leon
to the examples folder. It containsr/leon/home
&r/leon/config
.For context - this is meant to be a personal realm (or set of realms) that every gno.land user should have at some point. Later, the idea is to have a special user page which will fetch the
Render()
ofr/username/home
. This will serve like the profile of the user; and the home realm will most likely be upgradeable down the line.The reason I am making this a PR and not simply publishing it to the Portal Loop is that it allows for further code changes down the line.
examples/
get loaded into genesis first, and all other replayed addpkg transactions after that, making it possible to have "upgradeable" realms on Portal Loop.Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description