Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gnokey): add newline when showing data from query #2774

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Sep 9, 2024

Description

This PR adds a newline to make the data display of queries a bit nicer.

Before:

> gnokey query vm/qfile -data "gno.land/r/demo/wugnot" -remote https://rpc.gno.land:443
height: 0
data: wugnot.gno
z0_filetest.gno

After:

> gnokey query vm/qfile -data "gno.land/r/demo/wugnot" -remote https://rpc.gno.land:443
height: 0
data:
wugnot.gno
z0_filetest.gno

Similar case for other queries.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@leohhhn leohhhn requested review from jaekwon and a team as code owners September 9, 2024 13:41
@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (2873354) to head (0742803).

Files with missing lines Patch % Lines
tm2/pkg/crypto/keys/client/query.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2774      +/-   ##
==========================================
- Coverage   63.32%   60.52%   -2.81%     
==========================================
  Files         548      567      +19     
  Lines       78511    76810    -1701     
==========================================
- Hits        49715    46486    -3229     
- Misses      25443    26918    +1475     
- Partials     3353     3406      +53     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (+0.62%) ⬆️
contribs/gnofaucet 14.82% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.39% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 31, 2024
@jefft0
Copy link
Contributor

jefft0 commented Oct 31, 2024

Hi @leohhhn . Do you want to merge master to see if it fixes some of the failing CI tests?

@jefft0
Copy link
Contributor

jefft0 commented Oct 31, 2024

@leohhhn , can you fix the failed CI test for "Go Test / test"? It's failing because your commit changes the expected output for "data:". For example:

            FAIL: testdata/event_multi_msg.txtar:10: no match for `data: {` found in stdout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related review/triage-pending PRs opened by external contributors that are waiting for the 1st review
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

3 participants