-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Add a useful set of high quality pseudo-random number generators #2868
Open
wyhaines
wants to merge
11
commits into
gnolang:master
Choose a base branch
from
wyhaines:kh.add-prngs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyhaines
requested review from
jaekwon and
thehowl
and removed request for
a team
September 28, 2024 08:50
github-actions
bot
added
the
🧾 package/realm
Tag used for new Realms or Packages.
label
Sep 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2868 +/- ##
==========================================
- Coverage 63.32% 63.30% -0.02%
==========================================
Files 548 548
Lines 78511 78504 -7
==========================================
- Hits 49715 49695 -20
- Misses 25443 25454 +11
- Partials 3353 3355 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wyhaines
requested review from
deelawn,
mvertes,
moul,
piux2 and
zivkovicmilos
as code owners
October 7, 2024 02:27
wyhaines
force-pushed
the
kh.add-prngs
branch
from
October 15, 2024 22:15
7f3cc3f
to
4510d34
Compare
I ported a number of my pseudo-random number generator implementations from Ruby to Gno, building them be compatible with the standard Rand() implementation, so that any of these can be used as a drop-in replacement for the default PCG algorithm. All of these are faster than PCG, while still having competitive-to-superior statistical properties and predictability resistance. Further, the ISAAC family of generators are cryptographically secure, and when properly seeded, still have no known practical attack vectors.
Hey @wyhaines, can you update the PR branch with the master branch? 🙏 |
Revise all of the output to use ufmt.
Tidy gno.mods; add a Sprintf %f test.
…intf float formats a bit more to be closer to Go's support.
wyhaines
force-pushed
the
kh.add-prngs
branch
from
October 31, 2024 15:20
f56bcea
to
0fff418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 🌐 tendermint v2
Issues or PRs tm2 related
📦 🤖 gnovm
Issues or PRs gnovm related
🧾 package/realm
Tag used for new Realms or Packages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported a number of my pseudo-random number generator implementations from Ruby to gno while traveling to the retreat last weekend as an exercise in expanding my comfort level with gno code, and expanding my understanding of some of the code internals, while contributing code that others may find interesting or useful.
I added two xorshift generators, xorshift64* and xorshiftr128+. These are both many times faster than the PCG generator that is the gno default, and produce high quality randomness with great statistical qualities. In addition to these, I added both the 32-bit ISAAC implementation (with an added function to return 64 bit values), and the 64-bit ISAAC implementation. ISAAC is a stellar pseudo-random number generator. Both implementations are significantly faster than PCG (though not near so fast as the xorshift algorithms), while producing extremely high quality, cryptographically secure randomness that can not be differentiated from real randomness.
All of these were built to be compatible with the standard Rand() implementation. This means that any of these can be used as a drop-in replacement for the default PCG algorithm:
All of these leverage the
gno.land/p/demo/entropy
package to assist with seeding if no seed is provided. In the case of the ISAAC algorithms, they require 256 uint values for their seed, so they leverage a combination ofentropy
andxorshiftr128+
to generate any missing numbers in the provided seed.I also added a function to entropy to return uint64, to facilitate using it for seeding.
I added tests to entropy, and wrote tests for the other generators, as well.
There are a few other things that ended up in this PR. In order to make some fact based assertions about the performance of these generators, I included some code that can be ran via
gno run -expr
. i.e.gno run -expr 'averageISAAC()' isaac.gno
that can be used to get some benchmarks and some very simple self-statistical-analysis on the results, and when I did so, I discovered that the currentufmt.Sprintf
implementation didn't support any of the float output flags.I added float support to it's capabilities, which, in turn, required adding
FormatFloat
to thestrconv.gno/strconv.go
implementation in the standard library. I added a test to cover this.I also noticed that there is a test in
tm2/pkg/p2p
that is failing on both master and my branch. Specifically, there is a call tosw.Logger.Error()
that passes a message and an error, but not"err"
before the error. Adding that seemed to clear up the build failure. This, specifically, is line 222 ofswitch.go
.Currently there is one failing test, which is the code coverage check on tm2, because it is non-obvious to me how to setup a test to properly exercise that one changed line.
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description