-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the stdlib_diff tool to compare gno and go standard libraries #2869
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
@thehowl I took a look of this, the current status: 4 and 5 are fixed on eaf6a87
|
|
Removed the "review team" label because this is already reviewed by thehowl. |
…tion is the standard gno library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some more improvements overall, but I think with these few changes we're good to merge and iterate. Thanks, and sorry for the delay in the review!
btw, can you modify the gh-pages workflow? (.github/workflows/gh-pages) so it creates the report automatically on each push. Maybe put the report in the subdir I suggest you also try it out on a fork and link to a sample output, so we can check the workflow works correctly ahead of the merge. |
🛠 PR Checks Summary🔴 Maintainers must be able to edit this pull request (more info) Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🔴 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
@thehowl I followed your recommendations, here is the result :) thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thehowl Merged your PR sorry for having this extra step :) |
no worries :) |
…es (gnolang#2869) continuing the work started on gnolang#1425 thanks FloRichardAloeCorp for the great job on this issue 👍 closes gnolang#1310 <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: hthieu1110 <[email protected]> Co-authored-by: Florian Richard <[email protected]> Co-authored-by: Morgan Bazalgette <[email protected]>
continuing the work started on #1425
thanks FloRichardAloeCorp for the great job on this issue 👍
closes #1310
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description