-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support metadata for genesis txs #2941
Open
zivkovicmilos
wants to merge
22
commits into
master
Choose a base branch
from
dev/zivkovicmilos/genesis-timestamps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+389
−77
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
225235e
Save baseapp boilerplate
zivkovicmilos 28f8c33
Move out the hook modification from BaseApp
zivkovicmilos 56dfb9b
Revert "Move out the hook modification from BaseApp"
zivkovicmilos 0a08d81
Revert "Revert "Move out the hook modification from BaseApp""
zivkovicmilos ada450e
Revert "Revert "Revert "Move out the hook modification from BaseApp"""
zivkovicmilos 801b442
Allow for ctx modification
zivkovicmilos 7635859
Introduce a new genesis state type
zivkovicmilos a9ca81f
Fix faulty log line
zivkovicmilos 6cc4fc6
Simplify
zivkovicmilos ec30ae7
Add unit test for metadata tx
zivkovicmilos dcdbc02
Add unit test for non-metadata tx
zivkovicmilos ad72ac2
Update tm2/pkg/sdk/helpers.go
moul ea38da2
Merge branch 'master' into dev/zivkovicmilos/genesis-timestamps
zivkovicmilos 2026261
Merge branch 'master' into dev/zivkovicmilos/genesis-timestamps
zivkovicmilos 861bee0
ctx.Mode() -> mode
zivkovicmilos f0ce0f0
Fix updated import
zivkovicmilos a715d43
GenesisTxMetadata -> GnoTxMetadata
zivkovicmilos 1283d93
MetadataTx -> TxWithMetadata
zivkovicmilos 9ff26fe
Merge branch 'master' into dev/zivkovicmilos/genesis-timestamps
zivkovicmilos ad58e86
Merge branch 'master' into dev/zivkovicmilos/genesis-timestamps
zivkovicmilos a49c608
Merge branch 'master' into dev/zivkovicmilos/genesis-timestamps
zivkovicmilos 335048c
Modify GnoGenesisState
zivkovicmilos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -409,10 +409,17 @@ func generateGenesisFile(genesisFile string, pk crypto.PubKey, c *startCfg) erro | |
|
||
genesisTxs = append(pkgsTxs, genesisTxs...) | ||
|
||
metadataTxs := make([]gnoland.TxWithMetadata, 0, len(genesisTxs)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we avoid this and patch the genesisTxs file accordingly? |
||
for _, tx := range genesisTxs { | ||
metadataTxs = append(metadataTxs, gnoland.TxWithMetadata{ | ||
Tx: tx, | ||
}) | ||
} | ||
|
||
// Construct genesis AppState. | ||
gen.AppState = gnoland.GnoGenesisState{ | ||
Balances: balances, | ||
Txs: genesisTxs, | ||
Txs: metadataTxs, | ||
} | ||
|
||
// Write genesis state | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create a similar helper in the gnoland package.