feat(genesis): deployerAddress passed as parameter #2986
+38
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
📦 ⛰️ gno.land
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
=======================================
Coverage 63.30% 63.31%
=======================================
Files 548 548
Lines 78511 78514 +3
=======================================
+ Hits 49704 49713 +9
+ Misses 25452 25448 -4
+ Partials 3355 3353 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: 6h057 <[email protected]>
Villaquiranm
force-pushed
the
feat/configure-address-deployer-genesis
branch
from
2c5540c
to
c19da20
Compare
Villaquiranm
changed the title
omarsy
force-pushed
the
feat/configure-address-deployer-genesis
branch
from
c19da20
to
2d8ba6c
Compare
Villaquiranm
force-pushed
the
feat/configure-address-deployer-genesis
branch
from
2d8ba6c
to
c19da20
Compare
|
closes #2573 |
moul
requested changes
Oct 20, 2024
jefft0
added
the
review/triage-pending
…ddress-deployer-genesis
|
No longer blocked; please merge master to fix the go.mod CI and fix lint CI. I'll wait for the review team to do a first pass. |
n0izn0iz
suggested changes
Oct 31, 2024
| // Load Genesis TXs | ||
| genesisTxs, err := gnoland.LoadGenesisTxsFile(c.genesisTxsFile, c.chainID, c.genesisRemote) | ||
| if err != nil { | ||
| return fmt.Errorf("unable to load genesis txs file: %w", err) | ||
| } | ||
|
|
||
| signer := genesisTxs[0].Msgs[0].GetSigners()[0] |
There was a problem hiding this comment.
the first tx is not necessarily what has been passed to TxsAddPackages command
also loading the examples here will be removed from what I understand so maybe we should not change his file until #1952 is fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2573
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description