feat: add r/sys/params + params genesis support #3003
Conversation
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
github-actions
bot
added
the
📦 ⛰️ gno.land
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
|
I believe that Codecov has false negatives. It flags lines that are actually tested at least twice. |
Signed-off-by: moul <[email protected]>
moul
requested review from
jaekwon,
zivkovicmilos and
gfanton
and removed request for
jaekwon
Signed-off-by: moul <[email protected]>
| @@ -59,6 +59,7 @@ func TestingNodeConfig(t TestingTS, gnoroot string, additionalTxs ...std.Tx) (*g | |||
|
|
|||
| creator := crypto.MustAddressFromString(DefaultAccount_Address) // test1 | |||
|
|
|||
| params := LoadDefaultGenesisParamFile(t, gnoroot) | |||
There was a problem hiding this comment.
@gfanton, I think there is a problem with Codecov. Can you check why this line isn't reported?
There was a problem hiding this comment.
Because it's only used by txtar files in gno.land, unfortunately, the gno.land txtar doesn't set up coverage yet. I suggest you ignore this for now. Ideally, I would like to take some time centralize the logic of txtar from both gnovm and gno.land.
There was a problem hiding this comment.
I see you want to avoid losing too much coverage by taking advantage of txtar. Let me see if I can find a shortcut.
There was a problem hiding this comment.
I'm just looking for my PR to be green, because I wrote tests.
|
Ready for review. The CI is red, but the new code is tested. |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Closer to the current `// Realm:` output, and more git-friendly. Bigger example in #3003. Signed-off-by: moul <[email protected]>
r/sys/paramsgenesis/genesis_params.tomlDepends on #2920
Depends on #3003 (cherry-picked)
Blocking #2911