chore: regular block creation time (5s) #969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @jaekwon's comment
I've modified some configurations, and now gno creates blocks regularly (every 5 seconds) regardless of the creation of new transactions.
It seems that function
WaitForTxs()
must returnfalse
in order to create blocks regularly.gno/tm2/pkg/bft/consensus/config/config.go
Lines 79 to 81 in 5d32c39
gno/tm2/pkg/bft/consensus/state.go
Lines 838 to 849 in 5d32c39
At least the problem from issue #863 can be solved in this way. However, I'm not entirely sure about the purpose of
CreateEmptyBlocksInterval
.@moul
Do you think it's better to edit the
.toml
file as you did in #899?Also, do you have any estimated time for test4 (or test4-m1 for multi-node)? If the next testnet resolves the block time issue, the Onbloc team will be happy to work on the multinode testnet initiative #9 META Multinode Testnet Initiative
Contributors Checklist
BREAKING CHANGE: xxx
message was included in the descriptionMaintainers Checklist
CONTRIBUTING.md
BREAKING CHANGE:
in the body)