Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filtering transaction messages by multiple conditions #74

Conversation

jinoosss
Copy link
Member

Descriptions

Change to allow multiple transactional message filters.

Changes in this PR.

  • Receive a list of transaction message filter options.
  • If one of the conditions is met, the message filter options and the transaction's message list,
    the message can be retrieved.

Example

image

@ajnavarro
Copy link
Collaborator

We are suffering from Feature Creep on filters. Let me know what you think about #76

@zivkovicmilos
Copy link
Member

@ajnavarro

I'll merge this out and we can see how to have this same functionality much more elegantly

Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙏

@zivkovicmilos zivkovicmilos merged commit ae33bd6 into gnolang:main Aug 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants