Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jemalloc-sys: version macro being 0 #147

Open
yiwu-arbug opened this issue Mar 19, 2020 · 0 comments
Open

jemalloc-sys: version macro being 0 #147

yiwu-arbug opened this issue Mar 19, 2020 · 0 comments

Comments

@yiwu-arbug
Copy link

yiwu-arbug commented Mar 19, 2020 •
edited
Loading

The jemalloc.h produced by jemalloc-sys contain the following macros:

#define JEMALLOC_VERSION "0.0.0-0-g0000000000000000000000000000000000000000"
#define JEMALLOC_VERSION_MAJOR 0
#define JEMALLOC_VERSION_MINOR 0
#define JEMALLOC_VERSION_BUGFIX 0
#define JEMALLOC_VERSION_NREV 0
#define JEMALLOC_VERSION_GID "0000000000000000000000000000000000000000"

where for example JEMALLOC_VERSION_MAJOR should be 5 (for jemalloc 5.1.0). This will break c/c++ code that use the header to detect jemalloc version. Reproducible on master and jemalloc-sys:0.3.2. It was fine with jemalloc-sys:1.7.0.
@BusyJay BusyJay mentioned this issue Jul 20, 2020
Merged
BusyJay added a commit to tikv/jemallocator that referenced this issue Jul 21, 2020
@BusyJay
*: update jemalloc and simplify build (#1)
21c54a2 
- Remove all cross compilation and reduce supporting platforms
- Remove complicated checks and builds
- Update jemalloc to 5.2.1
- Fix gnzlbg#147

Signed-off-by: Jay Lee <[email protected]>
@yiwu-arbug yiwu-arbug mentioned this issue Jul 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yiwu-arbug