Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

librocksdb_sys: use tikv-jemalloc-sys #520

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Jul 21, 2020

Jemallocator has not been active for several months. We published our
own fork, which upgraded jemalloc to 5.2.1.

Jemallocator has not been active for several months. We published our
own fork, which upgraded jemalloc to 5.2.1.

Signed-off-by: Jay Lee <[email protected]>
@yiwu-arbug
Copy link
Collaborator

How did you fix gnzlbg/jemallocator#147?

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just curious, is there any purpose to upgrade jemalloc to the latest version?

@BusyJay
Copy link
Member Author

BusyJay commented Jul 22, 2020

How did you fix gnzlbg/jemallocator#147?

The VERSION file was skipped in the original implement.

is there any purpose to upgrade jemalloc to the latest version?

Latest version was discovered helpful in memory reclaim. Besides, we need extra APIs to add more metrics.

@yiwu-arbug yiwu-arbug merged commit 5e8633c into tikv:master Jul 22, 2020
@BusyJay BusyJay deleted the use-tikv-jemalloc branch July 23, 2020 02:25
yiwu-arbug pushed a commit that referenced this pull request Jul 23, 2020
Jemallocator has not been active for several months. We published our
own fork, which upgraded jemalloc to 5.2.1.

Signed-off-by: Jay Lee <[email protected]>
yiwu-arbug pushed a commit that referenced this pull request Jul 23, 2020
Jemallocator has not been active for several months. We published our
own fork, which upgraded jemalloc to 5.2.1.

Signed-off-by: Jay Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants