Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:err is never used #816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tiper-In-Github
Copy link

Fix the problem that err is overwritten and becomes invalid

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

coding have warnang: err is never used,Therefore, this problem was discovered and modified

📝 Changelog

Language Changelog
🇺🇸 English Add a new err variable to api.GetHourDiffer under other to receive the returns of the two calls respectively, and ignore the err (sysInfo, err := host.Info()) that is not used in the original logic of apis.ServerInfo
🇨🇳 Chinese 为other下的api.GetHourDiffer增加新的err变量,分别接收两次调用的返回,忽略掉apis.ServerInfo在原有逻辑中未使用的err(sysInfo, err := host.Info())

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript's definition is updated/provided or not needed
  • Changelog is provided or not needed

Fix the problem that err is overwritten and becomes invalid
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant