Skip to content

Commit

Permalink
Update scheduled tasks even if changes are pushed by "ActionsUser" (#…
Browse files Browse the repository at this point in the history
…32246)

Fix #32219

---------

Co-authored-by: delvh <[email protected]>
  • Loading branch information
Zettat123 and delvh authored Oct 13, 2024
1 parent 74664b0 commit 81aec6d
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion services/actions/notifier_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,20 @@ func (input *notifyInput) Notify(ctx context.Context) {
}

func notify(ctx context.Context, input *notifyInput) error {
shouldDetectSchedules := input.Event == webhook_module.HookEventPush && input.Ref.BranchName() == input.Repo.DefaultBranch
if input.Doer.IsActions() {
// avoiding triggering cyclically, for example:
// a comment of an issue will trigger the runner to add a new comment as reply,
// and the new comment will trigger the runner again.
log.Debug("ignore executing %v for event %v whose doer is %v", getMethod(ctx), input.Event, input.Doer.Name)

// we should update schedule tasks in this case, because
// 1. schedule tasks cannot be triggered by other events, so cyclic triggering will not occur
// 2. some schedule tasks may update the repo periodically, so the refs of schedule tasks need to be updated
if shouldDetectSchedules {
return DetectAndHandleSchedules(ctx, input.Repo)
}

return nil
}
if input.Repo.IsEmpty || input.Repo.IsArchived {
Expand Down Expand Up @@ -174,7 +183,6 @@ func notify(ctx context.Context, input *notifyInput) error {

var detectedWorkflows []*actions_module.DetectedWorkflow
actionsConfig := input.Repo.MustGetUnit(ctx, unit_model.TypeActions).ActionsConfig()
shouldDetectSchedules := input.Event == webhook_module.HookEventPush && input.Ref.BranchName() == input.Repo.DefaultBranch
workflows, schedules, err := actions_module.DetectWorkflows(gitRepo, commit,
input.Event,
input.Payload,
Expand Down

0 comments on commit 81aec6d

Please sign in to comment.