Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix milestone deadline and date related problems #32339

Merged
merged 11 commits into from
Nov 5, 2024
Merged

Fix milestone deadline and date related problems #32339

merged 11 commits into from
Nov 5, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 25, 2024 •
edited by wxiaoguang
Loading

Use zero instead of 9999-12-31 for deadline
Fix #32291

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2024
@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Oct 25, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 25, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 25, 2024
@lunny lunny marked this pull request as ready for review October 25, 2024 21:12
@wxiaoguang
Copy link
Contributor

The fix doesn't look good to me.

IMO it should be done separately.

  • For 1.23: use a migration to update database and remove all "9999-12-31" from code (or only leave a few places to handle API input).
  • For 1.22: only fix the value used by frontend but no need to touch other code. Actually there could be a one-line frontend patch to make it work without any backend change.

@wxiaoguang
Copy link
Contributor

Frontend fix: Fix absolute-date #32375

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 30, 2024
@lunny lunny removed the backport/v1.22 This PR should be backported to Gitea 1.22 label Nov 2, 2024
@lunny lunny added this to the 1.23.0 milestone Nov 2, 2024
@wxiaoguang wxiaoguang marked this pull request as draft November 5, 2024 04:12
@pull-request-size pull-request-size bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Nov 5, 2024
@wxiaoguang wxiaoguang force-pushed the lunny/fix-milestone branch 2 times, most recently from e708a61 to f8536d7 Compare November 5, 2024 04:53
@wxiaoguang wxiaoguang marked this pull request as ready for review November 5, 2024 04:54
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2024
@wxiaoguang
Copy link
Contributor

And: Quick fix milestone deadline 9999 for 1.22 #32423

@wxiaoguang wxiaoguang changed the title Fix milestone no deadline problem. Use zero instead of 9999-12-31 Fix milestone deadline and date related problems Nov 5, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 5, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) November 5, 2024 07:05
@wxiaoguang wxiaoguang merged commit 24b83ff into go-gitea:main Nov 5, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 5, 2024
@wxiaoguang wxiaoguang deleted the lunny/fix-milestone branch November 5, 2024 07:58
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 6, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f4c5144 
* giteaofficial/main: (21 commits)
  Use 8 as default value for git lfs concurrency (go-gitea#32421)
  Fix milestone deadline and date related problems (go-gitea#32339)
  Only query team tables if repository is under org when getting assignees (go-gitea#32414)
  Refactor RepoRefByType (go-gitea#32413)
  Refactor template ctx and render utils (go-gitea#32422)
  Refactor DateUtils and merge TimeSince (go-gitea#32409)
  Refactor markup package (go-gitea#32399)
  Add some handy markdown editor features (go-gitea#32400)
  Make LFS http_client parallel within a batch. (go-gitea#32369)
  Refactor repo legacy (go-gitea#32404)
  Replace DateTime with proper functions (go-gitea#32402)
  Fix git error handling (go-gitea#32401)
  Fix created_unix for mirroring (go-gitea#32342)
  Replace DateTime with DateUtils (go-gitea#32383)
  improve performance of diffs (go-gitea#32393)
  Refactor tests to prevent from unnecessary preparations (go-gitea#32398)
  Add artifacts test fixture (go-gitea#30300)
  Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (go-gitea#32365)
  Fix a number of typescript issues (go-gitea#32308)
  Update go dependencies (go-gitea#32389)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/frontend modifies/go Pull requests that update Go code modifies/migrations modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

JavaScript Error: Cannot Parse Date Format on Version 1.21.11 During Page Change in Milestones
4 participants
@lunny @wxiaoguang @wolfogre @GiteaBot