Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only query team tables if repository is under org when getting assignees #32414

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Only query team tables if repository is under org when getting assignees #32414

merged 5 commits into from
Nov 5, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 4, 2024 •
edited
Loading

It's unnecessary to query the team table if the repository is not under organization when getting assignees.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 4, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 4, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 4, 2024
@lunny lunny added type/bug backport/v1.22 This PR should be backported to Gitea 1.22 labels Nov 4, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 5, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 5, 2024
@Zettat123
Copy link
Contributor

It's unnecessary to query the team table if the repository is under organization when getting assignees.

Should be "if the repository is not under organization"?

@lunny lunny enabled auto-merge (squash) November 5, 2024 05:57
@lunny lunny merged commit 1887c75 into go-gitea:main Nov 5, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Nov 5, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 5, 2024
@GiteaBot
Copy link
Contributor

GiteaBot commented Nov 5, 2024

I was unable to create a backport for 1.22. @lunny, please send one manually. 🍵

go run ./contrib/backport 32414
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Nov 5, 2024
@lunny lunny deleted the lunny/small_opt branch November 5, 2024 15:46
lunny added a commit to lunny/gitea that referenced this pull request Nov 5, 2024
@lunny
Only query team tables if repository is under org when getting assign…
54b7691 
…ees (go-gitea#32414)

It's unnecessary to query the team table if the repository is not under
organization when getting assignees.
@lunny lunny mentioned this pull request Nov 5, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Nov 5, 2024
@lunny lunny modified the milestones: 1.24.0, 1.23.0 Nov 5, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 6, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f4c5144 
* giteaofficial/main: (21 commits)
  Use 8 as default value for git lfs concurrency (go-gitea#32421)
  Fix milestone deadline and date related problems (go-gitea#32339)
  Only query team tables if repository is under org when getting assignees (go-gitea#32414)
  Refactor RepoRefByType (go-gitea#32413)
  Refactor template ctx and render utils (go-gitea#32422)
  Refactor DateUtils and merge TimeSince (go-gitea#32409)
  Refactor markup package (go-gitea#32399)
  Add some handy markdown editor features (go-gitea#32400)
  Make LFS http_client parallel within a batch. (go-gitea#32369)
  Refactor repo legacy (go-gitea#32404)
  Replace DateTime with proper functions (go-gitea#32402)
  Fix git error handling (go-gitea#32401)
  Fix created_unix for mirroring (go-gitea#32342)
  Replace DateTime with DateUtils (go-gitea#32383)
  improve performance of diffs (go-gitea#32393)
  Refactor tests to prevent from unnecessary preparations (go-gitea#32398)
  Add artifacts test fixture (go-gitea#30300)
  Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (go-gitea#32365)
  Fix a number of typescript issues (go-gitea#32308)
  Update go dependencies (go-gitea#32389)
  ...
lunny added a commit that referenced this pull request Nov 6, 2024
@lunny
Only query team tables if repository is under org when getting assign…
16e51e9 
…ees (#32414) (#32426)

backport #32414 

It's unnecessary to query the team table if the repository is not under
organization when getting assignees.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @Zettat123 @GiteaBot @wolfogre @yp05327