Fixed EncodeJSONResponse body writing #1294
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, that RFC is more of a suggestion than a requirement :) |
|
@peterbourgon I'm a bit confused. I reported #1291 a while ago. In the response there you hinted that this should be fixed, as the EncodeJSONResponse is broken when the user implements a response with a 304 StatusCode. Should I include just the 304 for that fix, or why you closed this one exactly? |
|
Huh, me too apparently. |
|
@peterbourgon anything for me to do here? I guess the CI / Build issues are unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EncodeJSONResponse is not writing body for status codes 100-199, 204, 304 according to https://datatracker.ietf.org/doc/html/rfc7230#section-3.3
Fixes #1291