pprof prefix must be '/debug/pprof/' because of golang/go#14286

go-masonry · Nov 9, 2020 · 35ea739 · 35ea739
1 parent c47c69a
commit 35ea739
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/handlers/debug.go b/handlers/debug.go
@@ -15,7 +15,7 @@ import (
 )
 
 const (
-	internalPatternPrefix = "/internal"
+	internalPatternPrefix = "/debug"
 )
 
 // StatsInfo some statistics information
@@ -44,7 +44,7 @@ type debugHandlersDeps struct {
 //	- running stats
 func InternalDebugHandlers(deps debugHandlersDeps) []partial.HTTPHandlerPatternPair {
 	return []partial.HTTPHandlerPatternPair{
-		{Pattern: internalPatternPrefix + "/debug/vars", Handler: deps.DebugVars()},
+		{Pattern: internalPatternPrefix + "/vars", Handler: deps.DebugVars()},
 		{Pattern: internalPatternPrefix + "/dump", Handler: deps.DumpFunc()},
 		{Pattern: internalPatternPrefix + "/stats", Handler: deps.Stats()},
 	}

diff --git a/handlers/profile.go b/handlers/profile.go
@@ -7,13 +7,14 @@ import (
 )
 
 const (
-	profilePrefix = internalPatternPrefix + "/debug/pprof"
+	// the path of pprof must start with /debug/pprof because of https://github.com/golang/go/issues/14286
+	profilePrefix = internalPatternPrefix + "/pprof"
 )
 
 // InternalProfileHandlerFunctions profile handlers
 func InternalProfileHandlerFunctions() []partial.HTTPHandlerFuncPatternPair {
 	return []partial.HTTPHandlerFuncPatternPair{
-		{Pattern: profilePrefix, HandlerFunc: pprof.Index},
+		{Pattern: profilePrefix + "/", HandlerFunc: pprof.Index},
 		{Pattern: profilePrefix + "/cmdline", HandlerFunc: pprof.Cmdline},
 		{Pattern: profilePrefix + "/profile", HandlerFunc: pprof.Profile},
 		{Pattern: profilePrefix + "/symbol", HandlerFunc: pprof.Symbol},