Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UnsignedColumns idx out range #792

Closed
wants to merge 1 commit into from

Conversation

guihouchang
Copy link

fix:#713

@atercattus
Copy link
Member

Hello.
Can you add a test case (based on this) that will panic?

@atercattus
Copy link
Member

atercattus commented May 18, 2023

Same fix is here and here

@guihouchang
Copy link
Author

Hello. Can you add a test case (based on this) that will panic?

I don't know how to add this unit test.It looks very complicated. I need help

@lance6716
Copy link
Collaborator

Hello. Can you add a test case (based on this) that will panic?

I don't know how to add this unit test. It looks very complicated. I need help

Hi, do you find problems when try to use the test framework, or have no idea how to test it?

@guihouchang
Copy link
Author

have no idea how to test it, plz show me a example

@lance6716
Copy link
Collaborator

have no idea how to test it, plz show me a example

In fact I don't use canal, do you have a real use case that will meet this problem? We can mimic that API invocation and binlog content.

@lance6716
Copy link
Collaborator

replaced by #856

@lance6716 lance6716 closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants