fix bot detection

go-rod · Jul 7, 2023 · a68be36 · a68be36
1 parent 029f7bd
commit a68be36
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -20,4 +20,4 @@ jobs:
 
       - run: go run github.com/ysmood/golangci-lint@latest
 
-      - run: go test -coverprofile=coverage.out ./...
+      - run: go test ./...
diff --git a/service.go b/service.go
@@ -33,7 +33,7 @@ func New(addr, target string) *Bartender {
 }
 
 func (b *Bartender) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	if r.Method == http.MethodGet && r.Header.Get("Accept-Language") != "" {
+	if r.Method == http.MethodGet && r.Header.Get("Accept-Language") == "" {
 		b.RenderPage(w, r)
 
 		return

diff --git a/service_test.go b/service_test.go
@@ -27,12 +27,14 @@ func TestBasic(t *testing.T) {
 	proxy.Mux.HandleFunc("/", bt.ServeHTTP)
 
 	{
-		res := g.Req("", proxy.URL("/test?q=ok"))
+		// browser
+		res := g.Req("", proxy.URL("/test?q=ok"), http.Header{"Accept-Language": {"en"}})
 		g.Has(res.String(), "<body></body>")
 	}
 
 	{
-		res := g.Req("", proxy.URL("/test?q=ok"), http.Header{"Accept-Language": {"en"}})
+		// web crawler
+		res := g.Req("", proxy.URL("/test?q=ok"))
 		g.Has(res.String(), "/test?q=ok")
 	}
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,4 +20,4 @@ jobs:

		- run: go run github.com/ysmood/golangci-lint@latest

		- run: go test -coverprofile=coverage.out ./...
		- run: go test ./...