Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReflectionProperty::getValue() to use #[\ReturnTypeWillChange] #131

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

samsonasik
Copy link
Contributor

Using at goaop/framework:

*Before

Fatal error: During inheritance of ReflectionProperty: Uncaught ErrorException: Return type of Go\ParserReflection\ReflectionProperty::getValue($object = null) should either be compatible with ReflectionProperty::getValue(?object $object = null): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/samsonasik/www/framework-3/vendor/goaop/parser-reflection/src/ReflectionProperty.php:196
Stack trace:

After

D 126 / 210 ( 60%)
DDDDD...........................................DDDDDDD........ 189 / 210 ( 90%)
.....................                                           210 / 210 (100%)

Time: 00:01.921, Memory: 28.00 MB

@samsonasik
Copy link
Contributor Author

@lisachenko ready to merge 👍

@lisachenko lisachenko merged commit 8fc097d into goaop:master Feb 18, 2024
2 checks passed
@lisachenko
Copy link
Member

Merged, minus one deprecation warning.

@samsonasik
Copy link
Contributor Author

@lisachenko could you tag 4.0.0RC2 for it ? Thank you.

@lisachenko
Copy link
Member

I suggest to use temporary "4.x-dev" to avoid quick tags, once branch in the goaop/framework will work stable, we will tag all changes in one go

@lisachenko lisachenko added this to the 4.0.0 milestone Feb 18, 2024
@samsonasik
Copy link
Contributor Author

sure, updated goaop/framework@d3df92a

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants